Hi,

Thank you, just triggered the ci build on this, if all pass will merge it and port it to 3.2.x

Bye

Hi,

Tests are failing, so we do have cases where we rely on this conversion, looking in the code is possible to avoid this conversion specifying the double type at the end of the number, so something like: 35.927675D would this work for your use case ?

Regards

Hi,

Maybe another possible approach is replace the check: if (Math.abs(returnValue) < Float.MAX_VALUE) with a reconversion to the double value, to see if the value still matches, like:

float floatValue = (float) returnValue;
double check = (double) flatValue;
if(check == returnValue) {
 finalValue= flatValue;
} else {
finalValue = returnValue;
}

Can you verify if a check like this works in your case and update the PR?

One last thing (hopefully ...)

in case you update this PR can you add a test case for the case conversion error in OInsertStatementExecutionTest or in OUpdateStatementExecutionTest so we avoid to get regression in future.

I ll try it tomorrow, ty

Hi,

Tried to run the tests, they fail for formatting, you can run mvn spottless::apply to fix all the formatting issues.

(waiting for the test as well )

Hi, I had to rework this because the fix was going to create other failures, I made a fix that cover better the cases and landed it in 3.2.x and develop branch, closing this.